linux-kernel - Re: [PATCH] hid-multitouch: Filter collections by application usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110816114333.03e1f465@absol.kitzblitz>
Date:	Tue, 16 Aug 2011 11:43:33 +0200
From:	Nicolas Kaiser <nikai@...ai.net>
To:	Jeff Brown <jeffbrown@...roid.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	jkosina@...e.cz, rydberg@...omail.se, chatty@...c.fr,
	benjamin.tissoires@...c.fr
Subject: Re: [PATCH] hid-multitouch: Filter collections by application
 usage.

Just a nit below.

* jeffbrown@...roid.com:
(..)
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 58d0e7a..4ee21ac 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -213,6 +213,16 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  	struct mt_class *cls = td->mtclass;
>  	__s32 quirks = cls->quirks;
>  
> +	/* Only map fields from TouchScreen or TouchPad collections.
> +         * We need to ignore fields that belong to other collections
   ^
> +         * such as Mouse that might have the same GenericDesktop usages. */
   ^
You might want to use tabs here instead of spaces.

Best regards,
Nicolas Kaiser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/