linux-kernel - [PATCH] docs/kobject: Explain device.groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108161844.07095.bvanassche@acm.org>
Date:	Tue, 16 Aug 2011 18:44:06 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	linux-kernel@...r.kernel.org
Cc:	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Randy Dunlap <rdunlap@...otime.net>,
	rpearson@...temfabricworks.com
Subject: [PATCH] docs/kobject: Explain device.groups

Many drivers use device_create_file() where device.groups should be
used instead. Since this has not yet been documented, add a note in
Documentation/kobject.txt that explains why device.groups should be
used.

Signed-off-by: Bart Van Assche <bvanassche@....org>
Cc: Greg Kroah-Hartman <gregkh@...e.de>
Cc: Randy Dunlap <rdunlap@...otime.net>
---
 Documentation/kobject.txt |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt
index 3ab2472..0283c86 100644
--- a/Documentation/kobject.txt
+++ b/Documentation/kobject.txt
@@ -171,7 +171,10 @@ call to kobject_uevent():
 Use the KOBJ_ADD action for when the kobject is first added to the kernel.
 This should be done only after any attributes or children of the kobject
 have been initialized properly, as userspace will instantly start to look
-for them when this call happens.
+for them when this call happens. As an example, device attributes must be
+created by initializing device.groups properly before calling
+device_register() instead of calling device_create_file() after the device
+has been registered.
 
 When the kobject is removed from the kernel (details on how to do that is
 below), the uevent for KOBJ_REMOVE will be automatically created by the
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/