lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110816185057.GA4036@redhat.com>
Date:	Tue, 16 Aug 2011 20:50:57 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	Matt Fleming <matt@...sole-pimps.org>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()

daemonize() is only needed when a user-space task does kernel_thread().

r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
the soon-to-be-deprecated daemonize(). It is the only caller of
thread_enter() which actually does the call.

Note:
	- we are going to remove the sigdelset(blocked) code from
	  allow_signal(), this means that without this patch
	  thread_enter() can't work after that. Not to mention
	  daemonize() should be deprecated.

	- as a side effect, this patch changes ->comm. Hopefully
	  this is fine, and padapter->pnetdev->name probably makes
	  more sense anyway.

Signed-off-by: Oleg Nesterov <oleg@...hat.com>
---

 drivers/staging/rtl8712/osdep_service.h |    1 -
 1 file changed, 1 deletion(-)

--- 3.1/drivers/staging/rtl8712/osdep_service.h~2_daemonize_rtl8712	2011-07-28 14:06:57.000000000 +0200
+++ 3.1/drivers/staging/rtl8712/osdep_service.h	2011-08-16 20:36:39.000000000 +0200
@@ -203,7 +203,6 @@ static inline unsigned char _cancel_time
 
 static inline void thread_enter(void *context)
 {
-	daemonize("%s", "RTKTHREAD");
 	allow_signal(SIGTERM);
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ