linux-kernel - Re: [PATCH v2 0/3] make vfork killable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110816194204.GF2803@mtj.dyndns.org>
Date:	Tue, 16 Aug 2011 21:42:04 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Roland McGrath <roland@...k.frob.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Matt Fleming <matt.fleming@...ux.intel.com>,
	linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH v2 0/3] make vfork killable

Hello, Oleg.

On Mon, Aug 15, 2011 at 09:42:09PM +0200, Oleg Nesterov wrote:
> > * Regular job control and ptrace.
> > * vfork wait.
> > * cgroup freeze.
> 
> I still can't understand what exactly you have in mind.
>
> And to me vfork() is closer to nanoslep() than to cgroup_freezer.
> (As for cgroup_freezer, I agree it would be nice to reimplent it
>  in any case).

Maybe, it would be better to handle vfork() that way.  I'm not sure,
but if we can handle all three waits in the same manner, that would be
a plus too.  I'll think more about it.

> > The downside is that that wouldn't work with cgroup freeze at
> > all - there's no syscall to restart.
> 
> Sure. Still I don't understand why restart is not suitable for vfork
> and why it would be better to unify freezer/vfork.

It's still in the works but the user visible behavior is more
consistent both with and without ptrace.  I'm still trying to wrap my
head around consolidating freezer into it.  Let's see how it fans out.

> OK. Let's discuss this later, I hope you will cc me ;)

Oh, no need to worry about that. :)

> But what do you think about this series? It is simple, it doesn't
> play with restarts. In some sense it even simplifies the code because
> it removes one user of ->vfork_done. I don't think these patches can
> complicate the further changes you are going to do.
> 
> No?

Was too lost in the freezer land.  Will review first thing tomorrow.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/