linux-kernel - Re: [PATCH] staging: rtl8712: remove r8712_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E4AD2C5.6080205@lwfinger.net>
Date:	Tue, 16 Aug 2011 15:27:49 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Tejun Heo <tj@...nel.org>
CC:	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Matt Fleming <matt@...sole-pimps.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: remove r8712_cmd_thread()->daemonize()

On 08/16/2011 02:35 PM, Tejun Heo wrote:
> On Tue, Aug 16, 2011 at 08:50:57PM +0200, Oleg Nesterov wrote:
>> daemonize() is only needed when a user-space task does kernel_thread().
>>
>> r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
>> the soon-to-be-deprecated daemonize(). It is the only caller of
>> thread_enter() which actually does the call.
>>
>> Note:
>> 	- we are going to remove the sigdelset(blocked) code from
>> 	  allow_signal(), this means that without this patch
>> 	  thread_enter() can't work after that. Not to mention
>> 	  daemonize() should be deprecated.
>>
>> 	- as a side effect, this patch changes ->comm. Hopefully
>> 	  this is fine, and padapter->pnetdev->name probably makes
>> 	  more sense anyway.
>>
>> Signed-off-by: Oleg Nesterov<oleg@...hat.com>
>
> Acked-by: Tejun Heo<tj@...nel.org>
Acked-and-tested-by: Larry Finger <Larry.Finger@...inger.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/