linux-kernel - Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+XFjiqa84J97CxRWPNr98O2cyocwNSq5ULaKfentJXrkpPf9w@mail.gmail.com>
Date:	Tue, 16 Aug 2011 23:40:15 +0200
From:	Gábor Stefanik <netrolller.3d@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Akshay Joshi <me@...hayjoshi.com>, Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Karthigan Srinivasan <karthigan.srinivasan2@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.

2011/8/16 Gábor Stefanik <netrolller.3d@...il.com>:
> 2011/8/16 Pekka Enberg <penberg@...nel.org>:
>> 2011/8/16 Gábor Stefanik <netrolller.3d@...il.com>:
>>>> -
>>>> -//====================================
>>>> -// Internal variable for module
>>>> -//====================================
>>>> +/*============================================================================
>>>> +/* wb35rx.h --
>>>> +/*============================================================================
>>>
>>> I'm pretty sure this is not an accepted kernel comment style.
>>
>> What's the problem? I think it's OK for this particular patch.
>>
>
> The comments are not even valid C. The only reason why they do not
> break is that they are immediately followed by another,
> correctly-formatted (but separate) comment.

BTW, my suggested style here is the following:

/*============================================================================
 * wb35rx.h --
 *============================================================================*/

>
> --
> Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)