linux-kernel - Re: [RFC v1.1 2/5] crypto: ksign - digital signature verification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E4B9DD8.3060303@intel.com>
Date:	Wed, 17 Aug 2011 13:54:16 +0300
From:	Dmitry Kasatkin <dmitry.kasatkin@...el.com>
To:	James Morris <jmorris@...ei.org>
CC:	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	zohar@...ux.vnet.ibm.com
Subject: Re: [RFC v1.1 2/5] crypto: ksign - digital signature verification
 support



On 16/08/11 04:00, James Morris wrote:
> On Thu, 11 Aug 2011, Dmitry Kasatkin wrote:
>
>> +static int ksign_verify_rsa(struct key *key,
>> +		    const char *sig, int siglen,
>> +		       const char *h, int hlen)
>> +{
>> +	int err = -ENOMEM;
>> +	unsigned long len;
>> +	unsigned long mlen, mblen;
>> +	unsigned nret, l;
>> +	int valid, head, i;
>> +	unsigned char *out1 = NULL, *out2 = NULL;
>> +	MPI in = NULL, res = NULL, pkey[2];
>> +	uint8_t *p, *datap, *endp;
>> +	struct user_key_payload *ukp;
>> +	struct pubkey_hdr *pkh;
>> +
>> +	down_read(&key->sem);
>> +	ukp = key->payload.data;
>> +	pkh = (struct pubkey_hdr *)ukp->data;
>> +
>> +	if (pkh->version != 1)
>> +		return -EINVAL;
>> +
>> +	if (pkh->algo != PUBKEY_ALGO_RSA)
>> +		return -EINVAL;
> Are you supposed to be still holding key->sem here?
>
Of course not.
that was late addition. Should be goto as in following cases...

- Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/