| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110817120356.GG9959@quack.suse.cz> Date: Wed, 17 Aug 2011 14:03:56 +0200 From: Jan Kara <jack@...e.cz> To: David Horner <ds2horner@...il.com> Cc: linux-kernel@...r.kernel.org, fengguang.wu@...el.com, jack@...e.cz Subject: Re: [PATCH 2/5] writeback: dirty position control On Wed 17-08-11 02:40:19, David Horner wrote: > I noticed a significant typo below (another of those thousand eyes, > thanks to Jan Kara's post that started ne looking) : > > > +static unsigned long bdi_position_ratio(struct backing_dev_info *bdi, > > + unsigned long thresh, > ... > > + * For JBOD case, bdi_thresh (not bdi_dirty!) could fluctuate up to its > > + * own size, so move the slope over accordingly. > > + */ > > + if (unlikely(bdi_thresh > thresh)) > > + bdi_thresh = thresh; > > + /* > > + * scale global setpoint to bdi's: setpoint *= bdi_thresh / thresh > > + */ > > + x = div_u64((u64)bdi_thresh << 16, thresh | 1); > > ^ > I believe should be > > x = div_u64((u64)bdi_thresh << 16, thresh + 1); I've noticed this as well but it's mostly a consistency issue. 'thresh' is going to be large in practice so there's not much difference between thresh + 1 and thresh | 1. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists