linux-kernel - Re: [PATCH V4 0/3] ARM: mmp: add audio sram support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110817123221.GH28201@game.jcrosoft.org>
Date:	Wed, 17 Aug 2011 14:32:21 +0200
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Leo Yan <leoy@...vell.com>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	Haojian Zhuang <hzhuang1@...vell.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V4 0/3] ARM: mmp: add audio sram support

On 18:25 Mon 15 Aug     , Leo Yan wrote:
> 
> 
> On 08/15/2011 05:35 PM, Eric Miao wrote:
> >On Mon, Aug 15, 2011 at 5:12 PM, Jean-Christophe PLAGNIOL-VILLARD
> ><plagnioj@...osoft.com>  wrote:
> >>On 16:43 Mon 15 Aug     , Eric Miao wrote:
> >>>On Mon, Aug 15, 2011 at 11:11 AM, Haojian Zhuang
> >>><haojian.zhuang@...vell.com>  wrote:
> >>>>On Sun, 2011-08-14 at 20:09 -0700, Leo Yan wrote:
> >>>>>On mmp platform, there have two sram banks:
> >>>>>audio sram bank, and internal sram bank for video and PM.
> >>>>>So add the sram module to manage these sram banks.
> >>>>>
> >>>>>And register the sram banks so can dynamically alloc/free
> >>>>>the buffer.
> >>>>>
> >>>>>Leo Yan (3):
> >>>>>   ARM: mmp: add sram allocator
> >>>>>   ARM: mmp: register audio sram bank
> >>>>>   ARM: mmp: register internal sram bank
> >>>>>
> >>>>>  arch/arm/Kconfig                      |    1 +
> >>>>>  arch/arm/mach-mmp/Makefile            |    2 +-
> >>>>>  arch/arm/mach-mmp/brownstone.c        |   11 ++
> >>>>>  arch/arm/mach-mmp/include/mach/mmp2.h |   13 +++
> >>>>>  arch/arm/mach-mmp/include/mach/sram.h |   35 +++++++
> >>>>>  arch/arm/mach-mmp/mmp2.c              |    3 +
> >>>>>  arch/arm/mach-mmp/sram.c              |  168 +++++++++++++++++++++++++++++++++
> >>>>>  7 files changed, 232 insertions(+), 1 deletions(-)
> >>>>>  create mode 100644 arch/arm/mach-mmp/include/mach/sram.h
> >>>>>  create mode 100644 arch/arm/mach-mmp/sram.c
> >>>>>
> >>>>Acked-by: Haojian Zhuang<haojian.zhuang@...il.com>
> >>>
> >>>Looks good to me. Thanks Haojian. Applied to -devel.
> >>I've some reserve on the named pool they need to be managed at generic level
> >>not here
> >
> >What are their names? And your suggestions to fix this?
> >
> 
> For MMP platform have not only one bank, so now named the audio sram
> bank as "asram", and another sram bank as "isram" which is used by
> video/secure processor/pm.
> If other modules want to use the sram, just use the name string to
> get the gen pool handler, and then just call genalloc APIs.
> 
> I just wander if maintain the name in genalloc, then the name string
> we should maintain in the pool's structure or chunk's structure?
on the chunk

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/