linux-kernel - Re: [PATCH] usb: gadget: get rid of USB_GADGET_DUALSPEED and USB_GADGET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1108171224380.2100-100000@iolanthe.rowland.org>
Date:	Wed, 17 Aug 2011 12:25:27 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mina86@...a86.com>
cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Yang Rui Rui <ruirui.r.yang@...to.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: get rid of USB_GADGET_DUALSPEED and
 USB_GADGET_SUPERSPEED

On Wed, 17 Aug 2011, Michal Nazarewicz wrote:

> >>>> --- a/drivers/usb/gadget/file_storage.c
> >>>> +++ b/drivers/usb/gadget/file_storage.c
> >>>> @@ -3562,11 +3562,7 @@ static void fsg_resume(struct usb_gadget  
> >>>> *gadget)
> >>>>  static struct usb_gadget_driver		fsg_driver = {
> >>>> -#ifdef CONFIG_USB_GADGET_DUALSPEED
> >>>>  	.speed		= USB_SPEED_HIGH,
> >>>> -#else
> >>>> -	.speed		= USB_SPEED_FULL,
> >>>> -#endif
> >>>>  	.function	= (char *) fsg_string_product,
> >>>>  	.unbind		= fsg_unbind,
> >>>>  	.disconnect	= fsg_disconnect,
> 
> >>> You mustn't remove the .speed field entirely.  Set it to  
> >>> USB_SPEED_HIGH.
> 
> >> Please note that the field is not in fact removed.
> 
> > No, but you removed its initializer and as a result, it will be set to
> > 0 whereas it should be set to USB_SPEED_HIGH.
> 
> The initializer is still there. ;)  Only the “#” lines and the initializer
> in the “#else” part are removed.

I must be going selectively blind.  Never mind...

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/