linux-kernel - Re: [PATCH 2/2] mmc: prevent aggressive clock gating to race with ios updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbVOKoHi8AukX=qwHcp+oFEvYmXRNQ7xBg6hfX2AYbkgg@mail.gmail.com>
Date:	Wed, 17 Aug 2011 09:56:23 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	cjb@...top.org
Subject: Re: [PATCH 2/2] mmc: prevent aggressive clock gating to race with ios updates

On Mon, Aug 15, 2011 at 12:03 PM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:

> We have seen at least two different races when clock gating kicks in in a
> middle of ios structure update.
>
> First one happens when ios->clock is changed outside of aggressive clock
> gating framework, for example via mmc_set_clock(). The race might happen
> when we run following code:

Patch looks entirely sane if you deal with my considerations
in [1/2] replacing mmc_host_clk_gate_[disable|enable] with
plain mmc_host_clk_[ungate|gate]() or renamed versions
of these respectively.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/