linux-kernel - [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1313650112-17287-1-git-send-email-jeffrey.t.kirsher@intel.com>
Date:	Wed, 17 Aug 2011 23:48:32 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	linux-kernel@...r.kernel.org
Cc:	Bruce Allan <bruce.w.allan@...el.com>,
	Joe Perches <joe@...ches.com>,
	Anish Kumar <anish198519851985@...il.com>,
	Andy Whitcroft <apw@...onical.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags

From: Bruce Allan <bruce.w.allan@...el.com>

Commit 2011247 introduced additional style checks for signature tags in
patches which is good.  Unfortunately, now whenever patches are checked
by piping the output of 'git show' or 'stg show' through checkpatch it
warns not to use whitespace before all signature tags since these (and the
rest of the patch description) are indented.  Remove this test/warning.

Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
Cc: Joe Perches <joe@...ches.com>
Cc: Anish Kumar <anish198519851985@...il.com>
Cc: Andy Whitcroft <apw@...onical.com>
Tested-by:  Aaron Brown  <aaron.f.brown@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---
 scripts/checkpatch.pl |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9d761c9..a2a205a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1539,17 +1539,12 @@ sub process {
 		}
 
 # Check signature styles
-		if ($line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
-			my $space_before = $1;
-			my $sign_off = $2;
-			my $space_after = $3;
-			my $email = $4;
+		if ($line =~ /^\s*($signature_tags)(\s*)(.*)/) {
+			my $sign_off = $1;
+			my $space_after = $2;
+			my $email = $3;
 			my $ucfirst_sign_off = ucfirst(lc($sign_off));
 
-			if (defined $space_before && $space_before ne "") {
-				WARN("BAD_SIGN_OFF",
-				     "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
-			}
 			if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
 				WARN("BAD_SIGN_OFF",
 				     "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/