linux-kernel - Re: [PATCH] Staging: nvec: Fixed various style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108181005.10977.marvin24@gmx.de>
Date:	Thu, 18 Aug 2011 10:05:10 +0200
From:	Marc Dietich <marvin24@....de>
To:	Joe Perches <joe@...ches.com>
Cc:	Akshay Joshi <me@...hayjoshi.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Jiri Kosina <jkosina@...e.cz>,
	Vitaliy Ivanov <vitalivanov@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: nvec: Fixed various style issues.

Hey Joe,

> > On Thu, 2011-08-18 at 08:58 +0200, Marc Dietrich wrote:
> > Greg, I haven't yet heard of Joe (a reviewer, see:
> > http://driverdev.linuxdriverproject.org/pipermail/devel/2011-August/01921
> > 7.html) for some days now.
>
> I thought I was pretty clear in my reviewvand
> didn't need to reply further.
> 
> I think mixing index # and field comment in the
> same style isn't very readable.
> 
> It's your code, do what you think best.

this file certainly needs another cleanup (or maybe be moved into nvec_kbd.c). I 
just want to make "small" steps.

Thanks

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/