linux-kernel - Re: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1313657022.2128.116.camel@jtkirshe-mobl>
Date:	Thu, 18 Aug 2011 01:43:41 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Anish Kumar <anish198519851985@...il.com>,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: do not test/warn of leading whitespace
 before signature tags

On Thu, 2011-08-18 at 01:31 -0700, Joe Perches wrote:
> On Thu, 2011-08-18 at 01:26 -0700, Jeff Kirsher wrote:
> > I understand what you saying and asking, my point here is the that the
> > "default" style should be understood by checkpatch.pl and not produce
> > false warnings.
> 
> And I still disagree.
> 
> checkpatch should consider whatever
> input it gets as if it's a patch.
> 
> So, if you really want to feed
> git log output as input to checkpatch
> you should format that output
> appropriately and the best way to do
> that is to use git log --format=etc.
> 
> Don't suggest removing useful checks.
> 

I understand what your saying, and I think that your suggestion about
possibly implementing a "--input=git" option to checkpatch.pl might be a
happy middle ground to resolve the numerous false warnings this check
produces.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)