linux-kernel - RE: [PATCH] Media controller: Define media_entity_init() and media_entity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ADF30F4D7BDE934D9B632CE7D5C7ACA4047C4D0907DB@dbde03.ent.ti.com>
Date:	Thu, 18 Aug 2011 15:39:07 +0530
From:	"Ravi, Deepthy" <deepthy.ravi@...com>
To:	"Hiremath, Vaibhav" <hvaibhav@...com>,
	"mchehab@...radead.org" <mchehab@...radead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: RE: [PATCH] Media controller: Define media_entity_init() and
 media_entity_cleanup() conditionally


Thanks,
Deepthy Ravi.
________________________________________
From: Hiremath, Vaibhav
Sent: Wednesday, August 17, 2011 9:00 PM
To: Ravi, Deepthy; mchehab@...radead.org; linux-media@...r.kernel.org; linux-kernel@...r.kernel.org
Cc: linux-omap@...r.kernel.org
Subject: RE: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally

> -----Original Message-----
> From: Ravi, Deepthy
> Sent: Wednesday, August 17, 2011 4:05 PM
> To: mchehab@...radead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: linux-omap@...r.kernel.org; Hiremath, Vaibhav; Ravi, Deepthy
> Subject: [PATCH] Media controller: Define media_entity_init() and
> media_entity_cleanup() conditionally
>
> From: Vaibhav Hiremath <hvaibhav@...com>
>
> Defines the two functions only when CONFIG_MEDIA_CONTROLLER
> is enabled.
[Hiremath, Vaibhav] Deepthy,

You may want to mention about build failure without MEDIA_CONTROLLER option being enabled, especially if any sensor driver is being used between MC and non-MC framework compatible devices.
For example, OMAP3 and AM3517, where TVP5146 is being used but OMAP3 is based on MC framework and AM3517 is based on simple sub-dev based interface.

[Deepthy Ravi] Ok. I will change description to include that.

Thanks,
Vaibhav
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@...com>
> Signed-off-by: Deepthy Ravi <deepthy.ravi@...com>
> ---
>  include/media/media-entity.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index cd8bca6..c90916e 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -121,9 +121,18 @@ struct media_entity_graph {
>       int top;
>  };
>
> +#ifdef CONFIG_MEDIA_CONTROLLER
>  int media_entity_init(struct media_entity *entity, u16 num_pads,
>               struct media_pad *pads, u16 extra_links);
>  void media_entity_cleanup(struct media_entity *entity);
> +#else
> +static inline int media_entity_init(struct media_entity *entity, u16
> num_pads,
> +             struct media_pad *pads, u16 extra_links)
> +{
> +     return 0;
> +}
> +static inline void media_entity_cleanup(struct media_entity *entity) {}
> +#endif
>
>  int media_entity_create_link(struct media_entity *source, u16 source_pad,
>               struct media_entity *sink, u16 sink_pad, u32 flags);
> --
> 1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/