linux-kernel - Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP05o4J01FpphHgV5tpkFGNfTBbjhtScKjWZm4iLi3H1V=EKDQ@mail.gmail.com>
Date:	Thu, 18 Aug 2011 16:52:22 +0530
From:	"Munegowda, Keshava" <keshava_mgowda@...com>
To:	Anand Gadiyar <gadiyar@...com>, "Balbi, Felipe" <balbi@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again

On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@...com> wrote:
> This code section seems to have been accidentally copy pasted.
> It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> register and prevents the TLL mode from working correctly.
>
> Signed-off-by: Anand Gadiyar <gadiyar@...com>
> Cc: Keshava Munegowda <keshava_mgowda@...com>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> ---
> Against v3.1-rc2; tested against linux-next as of 20110817 as well.
>
> This probably needs to go to -stable as well. The original code
> by me worked fine but this was broken during the code reorganization
> Keshava did.
>
>  drivers/mfd/omap-usb-host.c |    1 -
>  1 file changed, 1 deletion(-)
>
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d
>                                | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
>                                | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
>
> -                       reg |= (1 << (i + 1));
>                } else
>                        continue;

Samuel Ortiz and balbi
please ack this patch

I am going to re-base runtime pm patches on top of this patch.


Regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/