linux-kernel - Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110818202938.GB28969@kernel.org>
Date:	Thu, 18 Aug 2011 22:29:38 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Tracey Dent <tdent48227@...il.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected


* Greg KH <gregkh@...e.de> wrote:

> On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
> > 
> > * Tracey Dent <tdent48227@...il.com> wrote:
> > 
> > > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > > > 
> > > > > When you try to build INTEL_MID_PTI without having PCI
> > > > > enabled. It fails like this-
> > > > > 
> > > > >  CC [M]  drivers/misc/pti.o
> > > > >  drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > > >  drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > > >  drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > > >  drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > > > > 
> > > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > > > 
> > > > I think (hope) that Greg already has a patch like this queued.
> > > > Greg- are you planning to push some patches soon?
> > > > 
> > > >
> > > 
> > > Okay, sorry for the noise then.
> > 
> > FYI, The fix is still not upstream, as of today's -git 
> > (72ed62bdc46d):
> > 
> > drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
> > drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
> 
> Yes, sorry, stuck at LinuxCon this week, will get it to Linus next 
> week. He's busy as well, so it's not like he could pull while 
> underwater anyway :)

No rush: the failures trigger pretty rately - just wanted to make 
sure it's not lost.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/