linux-kernel - Re: Oops in minixfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110818222409.GT2227@zod.bos.redhat.com>
Date:	Thu, 18 Aug 2011 18:24:10 -0400
From:	Josh Boyer <jwboyer@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Oops in minixfs_statfs

On Thu, Aug 18, 2011 at 10:16:20PM +0100, Al Viro wrote:
> On Thu, Aug 18, 2011 at 05:13:21PM -0400, Josh Boyer wrote:
> 
> > +	if (blocks != blocks_needed)
> > +		blocks = blocks_needed;
> 
> ????

Er.. yeah.  That's a left over from before I moved some verification
into fill_super, and then it got simplified to the point of being
utterly stupid.  It's been a long day.

I guess I could either just reassign sbi->s_[iz]map_blocks right then
and truly ignore the extra block, or just always pass the calculated
blocks_needed to count_free.  Which would you prefer?

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/