linux-kernel - Re: [PATCH 1/3] staging: olpc_dcon: remove noinit module variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2011 15:27:50 -0700
From:	Andres Salomon <dilinger@...ued.net>
To:	gregkh@...e.de
Cc:	linux-kernel@...r.kernel.org, cjb@...top.org,
	jon.nettleton@...il.com, devel@...verdev.osuosl.org
Subject: Re: [PATCH 1/3] staging: olpc_dcon: remove noinit module variable

Hi Greg,

Did you see these?  I haven't seen any emails about them being merged
into the staging tree yet..


On Thu, 21 Jul 2011
20:37:43 -0700 Andres Salomon <dilinger@...ued.net> wrote:

> This came from Jordan's original 2007 gxfb_dcon commit.  I've never
> seen or heard of it actually being used.  Presumably it was once
> useful for skipping hardware initialization when reloading the module
> over and over during driver development..
> 
> Signed-off-by: Andres Salomon <dilinger@...ued.net>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c index 750fe50..cf4b454 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -36,9 +36,6 @@
>  static int resumeline = 898;
>  module_param(resumeline, int, 0444);
>  
> -static int noinit;
> -module_param(noinit, int, 0444);
> -
>  /* Default off since it doesn't work on DCON ASIC in B-test OLPC
> board */ static int useaa = 1;
>  module_param(useaa, int, 0444);
> @@ -90,7 +87,7 @@ static int dcon_hw_init(struct dcon_priv *dcon, int
> is_init) }
>  	}
>  
> -	if (ver < 0xdc02 && !noinit) {
> +	if (ver < 0xdc02) {
>  		/* Initialize the DCON registers */
>  
>  		/* Start with work-arounds for DCON ASIC */
> @@ -106,7 +103,7 @@ static int dcon_hw_init(struct dcon_priv *dcon,
> int is_init) i2c_smbus_write_word_data(client, 0x3b, 0x002b);
>  		i2c_smbus_write_word_data(client, 0x41, 0x0101);
>  		i2c_smbus_write_word_data(client, 0x42, 0x0101);
> -	} else if (!noinit) {
> +	} else {
>  		/* SDRAM setup/hold time */
>  		i2c_smbus_write_word_data(client, 0x3a, 0xc040);
>  		i2c_smbus_write_word_data(client, 0x41, 0x0000);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/