linux-kernel - linux-next: build warning after merge of the moduleh tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110818150945.b429ef302fd45a6a309b52d4@canb.auug.org.au>
Date:	Thu, 18 Aug 2011 15:09:45 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: linux-next: build warning after merge of the moduleh tree

Hi Paul,

After merging the moduleh tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/base/power/common.c:51:1: warning: data definition has no type or storage class
drivers/base/power/common.c:51:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/base/power/common.c:51:1: warning: parameter names (without types) in function declaration
drivers/base/power/common.c:85:1: warning: data definition has no type or storage class
drivers/base/power/common.c:85:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/base/power/common.c:85:1: warning: parameter names (without types) in function declaration

Caused by the interaction of the module.h split up with commit
616d5814c605 ("PM: Reference counting of power.subsys_data") from the pm
tree.

I added this patch for today (Rafael, in your tree this needs to include
module.h) and will carry it as necessary:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Thu, 18 Aug 2011 15:06:10 +1000
Subject: [PATCH] PM: EXPORT_SYMBOL needs export.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/base/power/common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
index 1f58cf0..5b86d84 100644
--- a/drivers/base/power/common.c
+++ b/drivers/base/power/common.c
@@ -8,6 +8,7 @@
 
 #include <linux/init.h>
 #include <linux/kernel.h>
+#include <linux/export.h>
 #include <linux/slab.h>
 #include <linux/pm_clock.h>
 
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/