linux-kernel - Re: [PATCH] crypto: aesni-intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110819121516.GA2270@zod.bos.redhat.com>
Date:	Fri, 19 Aug 2011 08:15:16 -0400
From:	Josh Boyer <jwboyer@...hat.com>
To:	Herbert Xu <herbert@...dor.hengli.com.au>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

On Fri, Aug 19, 2011 at 04:12:08PM +0800, Herbert Xu wrote:
> On Fri, Aug 19, 2011 at 03:32:24PM +0800, Herbert Xu wrote:
> > 
> > Meanwhile I'll make a patch that ensures cryptd is registered
> > before aesni.
> 
> Please try this patch.  Thanks!

This worked great.  I'm confused why adding ivsize to the ablk_ecb_alg
"worked" as well, but looking at the traces again I agree this seems
like the actual problem.

Thanks!

> commit 9d4c522a113f6caa8b792ae829a25490fa87b1a2
> Author: Herbert Xu <herbert@...dor.apana.org.au>
> Date:   Fri Aug 19 16:11:23 2011 +0800
> 
>     crypto: cryptd - Use subsys_initcall to prevent races with aesni
>     
>     As cryptd is depeneded on by other algorithms such as aesni-intel,
>     it needs to be registered before them.  When everything is built
>     as modules, this occurs naturally.  However, for this to work when
>     they are built-in, we need to use subsys_initcall in cryptd.
>     
>     Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Tested-by: Josh Boyer <jwboyer@...hat.com>

> diff --git a/crypto/cryptd.c b/crypto/cryptd.c
> index e46d21a..671d4d6 100644
> --- a/crypto/cryptd.c
> +++ b/crypto/cryptd.c
> @@ -945,7 +945,7 @@ static void __exit cryptd_exit(void)
>  	crypto_unregister_template(&cryptd_tmpl);
>  }
>  
> -module_init(cryptd_init);
> +subsys_initcall(cryptd_init);
>  module_exit(cryptd_exit);
>  
>  MODULE_LICENSE("GPL");
> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/