linux-kernel - Re: [PATCH] apm-emulation: use wait_event_freezable() instead of freezer_[do_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110819142839.GH20085@htj.dyndns.org>
Date:	Fri, 19 Aug 2011 16:28:39 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH] apm-emulation: use wait_event_freezable() instead of
 freezer_[do_not_]count()

Hello,

On Thu, Aug 18, 2011 at 07:35:11PM +0200, Oleg Nesterov wrote:
> > Use wait_event_freezable() instead.
> >
> > The only annoyance is that wait_event_freezable() wakes up with
> > -ERESTART if there are pending signals
> 
> IOW, we do not have wait_event_freezable_uninterruptible/etc.

Yeap, we can add it but let's leave it alone for now.

> Perhaps we can introduce TASK_FREEZABLE ? It should be used along
> with TASK_UNINTERRUPTIBLE (like TASK_WAKEKILL). freeze_task() can
> use TASK_INTERRUPTIBLE | FREEZABLE for wake_up.
> 
> vfork() can use FREEZABLE too (although this is not needed in the
> long term, we should teach it to sleep in TASK_INTERRUPTIBLE).
> 
> But I feel you are going to reimplement freezer completely, in this
> case please ignore.

Hmmm... yeah, I just posted preparation patches for the freezer and
will now try to integrate with the rest of job control stuff.  Not
quite sure how it would turn out yet.  Let's see.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/