linux-kernel - Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E4E85C1.9060405@windriver.com>
Date:	Fri, 19 Aug 2011 11:48:17 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Anand Gadiyar <gadiyar@...com>
CC:	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h
 to fix build break

On 11-08-19 11:24 AM, Anand Gadiyar wrote:
> linux-next as of 20110817 fails to build if these two headers
> are not included. Including module.h is sufficient for now,
> but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
> to avoid a later build break.

Thanks -- We won't need to add both, since module.h will source
the export.h itself.    And we can't add export.h to mainline just
yet, since it won't exist there (it is only in linux-next now.)

I'll just add the right one to this file in the existing mtd patch.

Thanks for the report.

Paul.

> 
> Signed-off-by: Anand Gadiyar <gadiyar@...com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> ---
> Noticed this while testing another patch. I see similar
> changes to other files in drivers/mfd made by Paul recently.
> 
>  drivers/mfd/omap-usb-host.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -20,6 +20,8 @@
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> +#include <linux/export.h>
> +#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/clk.h>
>  #include <linux/dma-mapping.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/