linux-kernel - Re: [Patch v2 04/11]Power: DA9052 battery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110819162741.GC22761@oksana.dev.rtsoft.ru>
Date:	Fri, 19 Aug 2011 20:27:41 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	ashishj3 <ashish.jangam@...tcummins.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linaro-dev@...ts.linaro.org, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org, Dajun <dajun.chen@...semi.com>
Subject: Re: [Patch v2 04/11]Power: DA9052 battery driver

On Thu, Aug 04, 2011 at 06:17:52PM +0530, ashishj3 wrote:
> On Fri, 2011-07-22 at 18:22 +0530, ashishj3 wrote: 
> > Driver for DA9052 battery charger. This driver depends on DA9052 MFD core dirver
> > for definitions and methods.
> > 
> > Signed-off-by: David Dajun Chen <dchen@...semi.com>
> > Signed-off-by: Ashish Jangam <ashish.jangam@...tcummins.com>
> > ---
> > Changes since v2
> > - Correct code styling for inline functions
> > - Remove averaging algorithm
> > - Set use_for_apm thru board specific parameter
> > ---
> Any comments on this patch?

Despite some cosmetic issues, the patch looks OK to me.

So, I'm fine if it goes via MFD tree.

Although, if you ever need to respin this patch, try to make the
code fully conform to the Linux coding style.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/