linux-kernel - Re: [PATCH 02/16] freezer: don't unnecessarily set PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110819164306.GA24573@joana>
Date:	Fri, 19 Aug 2011 13:43:06 -0300
From:	Gustavo Padovan <padovan@...fusion.mobi>
To:	Tejun Heo <tj@...nel.org>
Cc:	rjw@...k.pl, menage@...gle.com, linux-kernel@...r.kernel.org,
	arnd@...db.de, oleg@...hat.com,
	Marcel Holtmann <marcel@...tmann.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	wwang <wei_wang@...lsil.com.cn>
Subject: Re: [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE
 explicitly

Hi Tejun,

* Tejun Heo <tj@...nel.org> [2011-08-19 16:16:08 +0200]:

> Some drivers set PF_NOFREEZE in their kthread functions which is
> completely unnecessary and racy - some part of freezer code doesn't
> consider cases where PF_NOFREEZE is set asynchronous to freezer
> operations.
> 
> In general, there's no reason to allow setting PF_NOFREEZE explicitly.
> Remove them and change the documentation to note that setting
> PF_NOFREEZE directly isn't allowed.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Marcel Holtmann <marcel@...tmann.org>
> Cc: "Gustavo F. Padovan" <padovan@...fusion.mobi>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: wwang <wei_wang@...lsil.com.cn>
> ---
>  Documentation/power/freezing-of-tasks.txt |    2 +-
>  drivers/bluetooth/btmrvl_main.c           |    2 --
>  drivers/mfd/twl4030-irq.c                 |    3 ---
>  drivers/mfd/twl6030-irq.c                 |    2 --
>  drivers/staging/rts_pstor/rtsx.c          |    2 --
>  5 files changed, 1 insertions(+), 10 deletions(-)

Acked-by: Gustavo F. Padovan <padovan@...fusion.mobi>

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/