linux-kernel - Re: m68k with mmu doesn't compile after 66d857b08b8c3ed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWfpZdwqtPgQKJHYVWRLKMXOeaMWV-mTBQxpE12XNTg_g@mail.gmail.com>
Date:	Sat, 20 Aug 2011 21:46:41 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Rob Landley <rob@...dley.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, gerg@...inux.org
Subject: Re: m68k with mmu doesn't compile after 66d857b08b8c3ed

Hi Rob,

You're really confusing me.

On Sat, Aug 20, 2011 at 21:18, Rob Landley <rob@...dley.net> wrote:
> The m68k build in 3.0 dies with this:
>
>  CC      arch/m68k/kernel/dma.o
> In file included from arch/m68k/kernel/dma.c:4:
> arch/m68k/kernel/dma_no.c: In function 'dma_sync_single_for_cpu':
> arch/m68k/kernel/dma_no.c:44: error: implicit declaration of function 'flush_dcache_range'

Your subject says "m68k with mmu doesn't compile", but here you're
obviously compiling for nommu, as dma.c includes dma_no.c if CONFIG_MMU
is not set.

> make[1]: *** [arch/m68k/kernel/dma.o] Error 1
> make: *** [arch/m68k/kernel] Error 2
>
> That file includes <asm/cacheflush.h>, which for m68k is:
>
> #ifdef __uClinux__
> #include "cacheflush_no.h"
> #else
> #include "cacheflush_mm.h"
> #endif
>
> The nommu header (cacheflush_no.h) does #define flush_dcache_range(),
> but the clacheflush_mm.h version does not.  I.E. you can only currently

Are you using a uClinux toolchain that defines __uClinux__, or not?

> build m68k for Coldfire, you can no longer build it for an actual m68k.

JFYI, it builds fine for all "actual m68ks" (with MMU) I'm interested in.
And I guess Greg will say the same for Coldfire and "actual m68ks" without
MMU...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/