linux-kernel - Re: [PATCH] Btrfs: use do_div to avoid compile errors on 32bit box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E4F11DA.5050209@cn.fujitsu.com>
Date:	Sat, 20 Aug 2011 09:46:02 +0800
From:	liubo <liubo2009@...fujitsu.com>
To:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
CC:	linux-btrfs@...r.kernel.org, chris.mason@...cle.com, dave@...os.cz
Subject: Re: [PATCH] Btrfs: use do_div to avoid compile errors on 32bit box

On 08/20/2011 09:34 AM, Liu Bo wrote:
> When doing div operation of u64 type, we need to be careful and use do_div
> to avoid compile ERROR on 32bit box:
> 
> "ERROR: "__udivdi3" [fs/btrfs/btrfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> 

Sorry, guys, I just sent a wrong version.

Plz ignore this one.  I'm sorry.

thanks,
liubo

> Signed-off-by: Liu Bo <liubo2009@...fujitsu.com>
> ---
>  fs/btrfs/extent-tree.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 80d6148..9b495ce 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -6796,14 +6796,14 @@ int btrfs_can_relocate(struct btrfs_root *root, u64 bytenr)
>  	index = get_block_group_index(block_group);
>  	if (index == 0) {
>  		dev_min = 4;
> -		min_free /= 2;
> +		do_div(min_free, 2);
>  	} else if (index == 1) {
>  		dev_min = 2;
>  	} else if (index == 2) {
>  		min_free *= 2;
>  	} else if (index == 3) {
>  		dev_min = fs_devices->rw_devices;
> -		min_free /= dev_min;
> +		do_div(min_free, dev_min);
>  	}
>  
>  	mutex_lock(&root->fs_info->chunk_mutex);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/