linux-kernel - Re: [PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h62ls8rqx.wl%tiwai@suse.de>
Date:	Sat, 20 Aug 2011 09:30:14 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	Johannes Berg <johannes@...solutions.net>,
	kernel-janitors@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
	Grant Likely <grant.likely@...retlab.ca>,
	linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

At Sat, 20 Aug 2011 08:12:41 +0200,
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@...u.dk>
> 
> The label outnodev is only used when kzalloc has not yet taken place or has
> failed, so there is no need for the call for kfree under this label.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> expression E1!=0,E2,E3,E4;
> statement S;
> iterator I;
> @@
> 
> (
> if (...) { ... when != kfree(x)
>                when != x = E3
>                when != E3 = x
> *  return ...;
>  }
> ... when != x = E2
>     when != I(...,x,...) S
> if (...) { ... when != x = E4
>  kfree(x); ... return ...; }
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Thanks, applied this one.
The rest three are left for review by Mark & Liam.


Takashi



> ---
>  sound/aoa/fabrics/layout.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c
> index 3fd1a7e..552b97a 100644
> --- a/sound/aoa/fabrics/layout.c
> +++ b/sound/aoa/fabrics/layout.c
> @@ -1073,10 +1073,10 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev)
>  	sdev->pcmid = -1;
>  	list_del(&ldev->list);
>  	layouts_list_items--;
> +	kfree(ldev);
>   outnodev:
>   	of_node_put(sound);
>   	layout_device = NULL;
> - 	kfree(ldev);
>  	return -ENODEV;
>  }
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/