linux-kernel - Re: [PATCH 01/16] freezer: fix current->state restoration race in refrigerator()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110820081356.GJ20085@htj.dyndns.org>
Date:	Sat, 20 Aug 2011 10:13:56 +0200
From:	Tejun Heo <tj@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	menage@...gle.com, linux-kernel@...r.kernel.org, arnd@...db.de,
	oleg@...hat.com
Subject: Re: [PATCH 01/16] freezer: fix current->state restoration race in
 refrigerator()

Hello, Rafael.

On Fri, Aug 19, 2011 at 11:08:59PM +0200, Rafael J. Wysocki wrote:
> On Friday, August 19, 2011, Tejun Heo wrote:
> > refrigerator() saves current->state before entering frozen state and
> > restores it before returning using __set_current_state(); however,
> > this is racy, for example, please consider the following sequence.
> > 
> > 	set_current_state(TASK_INTERRUPTIBLE);
> > 	try_to_sleep();
> 
> Did you mean try_to_freeze() here?

Heh, yeah, I'm constantly being confused among try_to_freeze(),
try_to_sleep() and try_to_wake_up().  Will update. ;)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/