linux-kernel - tpm: suppress durations sysfs output if not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E523430.1070003@linux.vnet.ibm.com>
Date:	Mon, 22 Aug 2011 06:49:20 -0400
From:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	Marcel Selhorst <m.selhorst@...rix.com>,
	James Morris <jmorris@...ei.org>
Subject: tpm: suppress durations sysfs output if not set

Suppress the output of durations if they were not read during driver 
initialization.
This is similar to other sysfs entries that return nothing if for some 
reason sending the commands to the TPM fails.

Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>

---
  drivers/char/tpm/tpm.c |    3 +++
  1 file changed, 3 insertions(+)

Index: linux-2.6/drivers/char/tpm/tpm.c
===================================================================
--- linux-2.6.orig/drivers/char/tpm/tpm.c
+++ linux-2.6/drivers/char/tpm/tpm.c
@@ -963,6 +963,9 @@ ssize_t tpm_show_durations(struct device
  {
      struct tpm_chip *chip = dev_get_drvdata(dev);

+    if (chip->vendor.duration[TPM_LONG] == 0)
+        return 0;
+
      return sprintf(buf, "%d %d %d [%s]\n",
                 jiffies_to_usecs(chip->vendor.duration[TPM_SHORT]),
                 jiffies_to_usecs(chip->vendor.duration[TPM_MEDIUM]),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/