linux-kernel - Re: [PATCH] ASoC: soc-core: use GFP_KERNEL flag for kmalloc in snd_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E52368D.4050301@ti.com>
Date:	Mon, 22 Aug 2011 11:59:25 +0100
From:	Liam Girdwood <lrg@...com>
To:	Axel Lin <axel.lin@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: soc-core: use GFP_KERNEL flag for kmalloc  in snd_soc_cnew

On 20/08/11 04:03, Axel Lin wrote:
> GFP_ATOMIC is not needed here, use GFP_KERNEL instead.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/soc-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index ae93aa8..b6d8716 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1913,7 +1913,7 @@ struct snd_kcontrol *snd_soc_cnew(const struct snd_kcontrol_new *_template,
>  
>  	if (prefix) {
>  		name_len = strlen(long_name) + strlen(prefix) + 2;
> -		name = kmalloc(name_len, GFP_ATOMIC);
> +		name = kmalloc(name_len, GFP_KERNEL);
>  		if (!name)
>  			return NULL;
>  

Acked-by: Liam Girdwood <lrg@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/