linux-kernel - Re: [PATCH] staging: iio: industrialio-core: Fix compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs6YxhF5nhb=JMSVKWOVjiZXOehFZDESeYcrVvmU21fnrhdw@mail.gmail.com>
Date:	Mon, 22 Aug 2011 14:44:20 +0300
From:	Maxin B John <maxin.john@...il.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Manuel Stahl <manuel.stahl@....fraunhofer.de>,
	Bryan Freed <bfreed@...omium.org>, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: industrialio-core: Fix compiler warning

On Mon, Aug 22, 2011 at 2:37 PM, Jonathan Cameron <jic23@....ac.uk> wrote:
> On 08/22/11 11:08, Maxin B. John wrote:
>> drivers/staging/iio/industrialio-core.c: In function
>> 'iio_device_add_event_sysfs':
>> drivers/staging/iio/industrialio-core.c:914: warning: 'mask' may be
>> used uninitialized in this function
> Thanks for the patch.  It's actually a driver bug if this occurs.
> We could have had a WARN_ON to let userspace know about the bug and
> indeed taken the error route you suggest but
> the relevant code has actually undergone a rewrite anyway so the
> bit you are fixing doesn't exist any more anyway.

 Yes, That makes more sense.

> See http://git.kernel.org/?p=linux/kernel/git/jic23/iio-blue.git;a=summary
> For our current dev tree (eats babies and includes all sorts of stuff
> that hasn't been reviewed yet - so beware).

Thanks for sharing  this (scary) info :)

Best Regards,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/