linux-kernel - [PATCH] arch/s390/kernel/ipl.c: correct error detection check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1314013594-25651-1-git-send-email-julia@diku.dk>
Date:	Mon, 22 Aug 2011 13:46:34 +0200
From:	Julia Lawall <julia@...u.dk>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	kernel-janitors@...r.kernel.org,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com, Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	sumsaha@...il.com
Subject: [PATCH] arch/s390/kernel/ipl.c: correct error detection check

From: Julia Lawall <julia@...u.dk>

reipl_fcp_kset was just initialized, so it appears that it should be tested
instead of reipl_kset.

Signed-off-by: Julia Lawall <julia@...u.dk>
Reported-by: Suman Saha <sumsaha@...il.com>

---
 arch/s390/kernel/ipl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index 04361d5..ee28e06 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -1220,7 +1220,7 @@ static int __init reipl_fcp_init(void)
 	/* sysfs: create fcp kset for mixing attr group and bin attrs */
 	reipl_fcp_kset = kset_create_and_add(IPL_FCP_STR, NULL,
 					     &reipl_kset->kobj);
-	if (!reipl_kset) {
+	if (!reipl_fcp_kset) {
 		free_page((unsigned long) reipl_block_fcp);
 		return -ENOMEM;
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/