linux-kernel - Re: [PATCH] mfd: twl6030-irq: Make sure to call request_irq before using the irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110822133254.GP4607@sortiz-mobl>
Date:	Mon, 22 Aug 2011 15:32:54 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Rajendra Nayak <rnayak@...com>,
	Balaji T K <balajitk@...com>,
	Santosh Shilimkar <santosh.shilimkar@...com>
Subject: Re: [PATCH] mfd: twl6030-irq: Make sure to call request_irq before
 using the irq_num

Hi Axel,

On Thu, Aug 11, 2011 at 03:21:00PM +0800, Axel Lin wrote:
> I was trying to fix the error handling part because in the case of
> request_irq failure, it should call kthread_stop instead of free_irq.
> But it seems more reasonable to do request_irq before calling kthread_run.
I don't have the hardware, but that makes sense to me.
Unless some from TI NACK this patch, I'm applying it.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/