linux-kernel - [PATCH] xhci: Redundant check for xhci->devs[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+OjSzww54ogPKD4PuKR6=37fbTBwnWq5yw2NSTZM0pH1N8S1g@mail.gmail.com>
Date:	Mon, 22 Aug 2011 21:06:59 +0530
From:	sifram rajas <sifram.rajas@...il.com>
To:	sarah.a.sharp@...el.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: [PATCH] xhci: Redundant check for xhci->devs[]

Hi Sarah,

This patch is for linux-3.0.3.

In the xhci_check_args() function in xhci.c, there is a redundant
check for xhci->devs.

This is redundant because the struct xhci_hcd->devs is actually
defined as a static array
of pointers and is not a pointer to a pointer.

Signed-off-by: Sifram Rajas <sifram.rajas@...il.com>
---
drivers/usb/host/xhci.c |   3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c   2011-08-17 23:27:16.000000000 +0530
+++ b/drivers/usb/host/xhci.c   2011-08-22 20:43:34.250000000 +0530
@@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
               return -ENODEV;

       if (check_virt_dev) {
-               if (!udev->slot_id || !xhci->devs
-                       || !xhci->devs[udev->slot_id]) {
+               if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
                       printk(KERN_DEBUG "xHCI %s called with unaddressed "
                                               "device\n", func);
                       return -EINVAL;

Thanks,
Sifram Rajas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/