linux-kernel - Re: [PATCH] dma-debug: hash_bucket_find needs to allow for offsets within an entry (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110822172328.GC12337@hmsreliant.think-freely.org>
Date:	Mon, 22 Aug 2011 13:23:28 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	"Roedel, Joerg" <Joerg.Roedel@....com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Divy LeRay <divy@...lsio.com>,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] dma-debug: hash_bucket_find needs to allow for offsets
 within an entry (v2)

On Mon, Aug 22, 2011 at 06:46:26PM +0200, Roedel, Joerg wrote:
> Hi Neil,
> 
> I applied your patch and did some minor changes and fixed one problem I
> have seen. Find the edited version appended, when this is fine for you I
> push it.
> 
> Thanks,
> 	Joerg
> 
> On Mon, Aug 08, 2011 at 03:13:54PM -0400, Neil Horman wrote:
> > +		range += (1 << HASH_FN_SHIFT);
> > +		put_hash_bucket(*bucket, flags);
> > +		index.dev_addr -= HASH_FN_SHIFT;
> 
> This should be index.dev_addr -= (1 << HASH_FN_SHIFT), right?
> 
Yup, thats right, good catch, thanks!
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/