linux-kernel - Re: [PATCH 3/4] string: introduce memchr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110822145050.e3471fa0.akpm@linux-foundation.org>
Date:	Mon, 22 Aug 2011 14:50:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Akinobu Mita <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, Joern Engel <joern@...fs.org>,
	logfs@...fs.org, Marcin Slusarz <marcin.slusarz@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 3/4] string: introduce memchr_inv

On Mon, 22 Aug 2011 13:52:18 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > +	value64 = value | value << 8 | value << 16 | value << 24;
> > +	value64 = (value64 & 0xffffffff) | value64 << 32;
> > +	prefix = 8 - ((unsigned long)start) % 8;
> > +
> > +	if (prefix) {
> > +		u8 *r = check_bytes8(start, value, prefix);
> > +		if (r)
> > +			return r;
> > +		start += prefix;
> > +		bytes -= prefix;
> > +	}
> > +
> > +	words = bytes / 8;
> > +
> > +	while (words) {
> > +		if (*(u64 *)start != value64)
> 
> OK, problem.  This will explode if passed a misaligned address on
> certain (non-x86) architectures.

pls ignore.  As Marcin points out, I can't read.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/