linux-kernel - Re: [PATCH] mfd: tps6586x: add api to power off tps6586x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN1soZzkmP=ckzAOJv59YfYtFU63nC9j-Oa+cM5z674yf0Mihw@mail.gmail.com>
Date:	Mon, 22 Aug 2011 13:06:02 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Wei Ni <wni@...dia.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"mike@...pulab.co.il" <mike@...pulab.co.il>,
	Nitin Kumbhar <nkumbhar@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: tps6586x: add api to power off tps6586x

On Mon, Aug 22, 2011 at 11:47 AM, Wei Ni <wni@...dia.com> wrote:
> Hi, Samuel
> Thanks for your comments.
> Please check the following lines with [Wei Ni]
>
> Thanks
> Wei.
>
>
>>-----Original Message-----
>>From: Samuel Ortiz [mailto:sameo@...ux.intel.com]
>>Sent: Monday, August 22, 2011 7:05 AM
>>To: Wei Ni
>>Cc: mike@...pulab.co.il; gking@...dia.com; Nitin Kumbhar; linux-kernel@...r.kernel.org
>>Subject: Re: [PATCH] mfd: tps6586x: add api to power off tps6586x
>>
>>Hi Wei,
>>
>>On Thu, Jul 28, 2011 at 02:30:36PM +0800, wni@...dia.com wrote:
>>> +static struct i2c_client *tps6586x_i2c_client;
>>That's not vey nice. By doing so, you're preventing anyone to have more than
>>one of those chips in their boards.
> [Wei Ni] oh yes, I didn’t consider this issue. We use i2c_register_board_info()
> to register the tps6586x in the board file, but it didn't return the handle.
> Do you have any ideas?
>>
>>

Since there's no parameter in pm_power_off(), invoking power off
function is a known issue
for i2c devices. And we can't get i2c client in board file.

Maybe we can add a LDO mapping in regulator driver. Since power-off
function is always
customized in board file. We can disable this regulator while
power_off() is called. So even
multiple PMICs is installed in one system, we only handle the real one
to shutdown the
whole system.

Samuel & Mark,
Do you think that it's worth to do?

Thanks
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/