linux-kernel - Re: [PATCH] power_supply: s3c_adc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Aug 2011 17:52:31 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Vasily Khoruzhick <anarsoul@...il.com>
Subject: Re: [PATCH] power_supply: s3c_adc_battery: Needs module.h

On Sun, Aug 21, 2011 at 03:01:41PM +0800, Axel Lin wrote:
> power/s3c_adc_battery:.c uses interfaces from linux/module.h,
> so it should include that file.
> 
> This patch fixes below build error:
> 
>   CC      drivers/power/s3c_adc_battery.o
> drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype
> make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---

Vasily Khoruzhick sent a similar fix.

I'm going to send a pull request with these fixes soon.

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/