linux-kernel - Re: [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent when reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Aug 2011 16:09:26 +0200
From:	Greg Kurz <gkurz@...ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Bruno Prémont <bonbons@...ux-vserver.org>,
	containers@...ts.linux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Send a SIGCHLD to the init's pid namespace parent
 when reboot

On Tue, 2011-08-23 at 15:33 +0200, Oleg Nesterov wrote:
> [...]
> At least now I understand why did you mention si_code/CLD before. You
> meant waitid(). I thought you were talking about the death-notifications
> which can't report CLD_ you need.
> 
> I strongly object. We shouldn't uglify wait_task_zombie() to solve the
> very specific problem.
> 
> And once again. sub_init->parent does wiat(&status) and sees
> WIFSIGNALED() && WTERMSIG(status) == SIGHUP. This can only mean that
> sys_reboot(LINUX_REBOOT_CMD_RESTART) was called. It _can not_ be really
> killed by SIGHUP, it must be CMD_RESTART.
> 
> Why this can't work? Why do you want the additional complications?
> 

I don't see either what could go wrong with you approach. It doesn't
mess with critical wait() or signal paths. It's definitely the way to
go.

Thanks.

-- 
Gregory Kurz                                     gkurz@...ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)534 638 479                           Fax +33 (0)561 400 420

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/