linux-kernel - Re: [PATCH] libfs: fix simple_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyhjDnCDZrnR6P9DGhXV80bm_mRB6nNo=86ctz1aNhVfmg@mail.gmail.com>
Date:	Wed, 24 Aug 2011 00:05:06 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Andi Kleen <ak@...ux.intel.com>,
	Huang Ying <ying.huang@...el.com>
Subject: Re: [PATCH] libfs: fix simple_attr_write on 32bit machine

2011/8/23 Greg KH <greg@...ah.com>:
> On Sat, Jul 09, 2011 at 02:00:26PM +0900, Akinobu Mita wrote:
>> Assume that /sys/kernel/debug/dummy64 is debugfs file created by
>> debugfs_create_x64().
>>
>>       # cd /sys/kernel/debug
>>       # echo 0x1234567812345678 > dummy64
>>       # cat dummy64
>>       0x0000000012345678
>>
>>       # echo 0x80000000 > dummy64
>>       # cat dummy64
>>       0xffffffff80000000
>>
>> The value more than INT_MAX cannot be written to the debugfs file
>> created by debugfs_create_u64 or debugfs_create_x64 on 32bit machine.
>> Because simple_attr_write() uses simple_strtol() for the conversion.
>>
>> To fix this, use simple_strtoll() instead.
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>
> Do we have any debugfs files that need this change in the tree now for
> 3.1 or newer?

This patch has already been merged into 3.0.  Some files are created
debugfs_create_[ux]64 with write permission and affected by this bug.

hwpoison/corrupt-filter-flags-mask
hwpoison/corrupt-filter-flags-value
hwpoison/corrupt-filter-memcg
apei/einj/param1
apei/einj/param2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/