[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAC5umygVhjAAH-o_KGp+hkHeqfGpX9J+GP8aS68H_=GSLEdNWg@mail.gmail.com>
Date: Wed, 24 Aug 2011 00:26:41 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/4] debug-pagealloc: add support for highmem pages
2011/8/23 Andrew Morton <akpm@...ux-foundation.org>:
> This seems more complicated than is needed. Couldn't we just do
>
> static void poison_page(struct page *page)
> {
> void *addr;
>
> preempt_disable();
> addr = kmap_atomic(page);
> set_page_poison(page);
> memset(addr, PAGE_POISON, PAGE_SIZE);
> kunmap_atomic(addr);
> preempt_enable();
> }
>
> ?
This code looks much better. I'll update the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists