linux-kernel - Re: [PATCH 04/16] freezer: implement and use kthread_freezable_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110823154239.GA25808@redhat.com>
Date:	Tue, 23 Aug 2011 17:42:39 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	rjw@...k.pl, menage@...gle.com, linux-kernel@...r.kernel.org,
	arnd@...db.de, Jens Axboe <axboe@...nel.dk>,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>
Subject: Re: [PATCH 04/16] freezer: implement and use
	kthread_freezable_should_stop()

Hi Tejun,

On 08/22, Tejun Heo wrote:
>
> > OK, but then we do
> >
> > 	current->flags &= ~PF_FREEZING;
> >
> > since PF_FROZEN wasn't cleared this can race with
> >
> > 	p->flags &= ~PF_FROZEN;
> >
> > No?
>
> Indeed, I removed PF_FREEZING and moved PF_FROZEN to __refrigerator()
> in later patches, so it's already gone.

OK, thanks.

> Patches could have been
> sequenced better, I suppose.  But, sequencing fixes for different
> races was already pretty challenging.  :)

... and it also makes sense to try to read the whole seried before
asking the question.

although this is not simple. Especially because currently I can't
read it faster than one patch per day ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/