linux-kernel - Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sjoshx2k.fsf@ti.com>
Date:	Tue, 23 Aug 2011 10:11:47 -0700
From:	Kevin Hilman <khilman@...com>
To:	Janusz Krzysztofik <jkrzyszt@....icnet.pl>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs

Janusz Krzysztofik <jkrzyszt@....icnet.pl> writes:

> With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove 
> ifdefs", access to build time conditionally omitted 'suspend_wakeup' 
> member of the 'gpio_bank' structure has been placed unconditionally in 
> function _set_gpio_wakeup(), which is always built. This resulted in the 
> driver compilation broken for certain OMAP1, i.e., non-OMAP16xx, 
> configurations.
>
> Really required or not in previously excluded cases, define this 
> structure member unconditionally as a fix.
>
> Tested with a custom OMAP1510 only configuration.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@....icnet.pl>

Verified that this fixes a build problem when building for OMAP1
(730/850 only)

Acked-by: Kevin Hilman <khilman@...com>

Grant, can you queue this as a fix for 3.1-rc?

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/