linux-kernel - Re: [PATCH -next] usb: fix dwc3 build when USB_GADGET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110823185235.GA11299@legolas.emea.dhcp.ti.com>
Date:	Tue, 23 Aug 2011 21:52:36 +0300
From:	Felipe Balbi <balbi@...com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	akpm <akpm@...ux-foundation.org>, gregkh@...e.de,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>, linux-omap@...r.kernel.org
Subject: Re: [PATCH -next] usb: fix dwc3 build when USB_GADGET_DWC3 is not
 enabled

Hi,

On Tue, Aug 23, 2011 at 11:07:02AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix build error when CONFIG_USB_GADGET_DWC3 is not enabled:
> 
> ERROR: "dwc3_send_gadget_ep_cmd" [drivers/usb/dwc3/dwc3.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> ---
>  drivers/usb/dwc3/debugfs.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-next-20110823.orig/drivers/usb/dwc3/debugfs.c
> +++ linux-next-20110823/drivers/usb/dwc3/debugfs.c
> @@ -437,7 +437,9 @@ static int dwc3_testmode_open(struct ino
>  	struct dwc3_gadget_ep_cmd_params par0;
>  	struct dwc3_gadget_ep_cmd_params par1;
>  	struct dwc3_trb         trb;
> +#ifdef CONFIG_USB_GADGET_DWC3
>  	int ret;
> +#endif
>  	u8 *buf0;
>  	u8 *buf1;
>  
> @@ -478,8 +480,10 @@ static int dwc3_testmode_open(struct ino
>  
>  	dwc3_send_testmode_cmd(dwc, 1);
>  
> +#ifdef CONFIG_USB_GADGET_DWC3
>  	ret = dwc3_send_gadget_ep_cmd(dwc, 0, DWC3_DEPCMD_STARTTRANSFER, &par0);
>  	ret = dwc3_send_gadget_ep_cmd(dwc, 1, DWC3_DEPCMD_STARTTRANSFER, &par1);
> +#endif

instead of adding the ifdef here, would you add it gadget.h and provide
a nop when we're not building the gadget side ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)