linux-kernel - Re: [PATCH] nohz: remove "Switched to NOHz mode" debugging messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1314126777.1659.2.camel@Joe-Laptop>
Date:	Tue, 23 Aug 2011 12:12:57 -0700
From:	Joe Perches <joe@...ches.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH] nohz: remove "Switched to NOHz mode" debugging messages

On Tue, 2011-08-23 at 13:20 +0200, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> When performing cpu hotplug tests the kernel printk log buffer gets flooded
> with pointless "Switched to NOHz mode..." messages. Especially when afterwards
> analyzing a dump this might have removed more interesting stuff out of the
> buffer.
> Assuming that switching to NOHz mode simply works just remove the printk.

> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
[]
> -
> -	printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());

Though I don't know if these are actually particularly
useful messages, perhaps pr_info_ratelimited() might
be appropriate instead.

> @@ -793,10 +791,8 @@ void tick_setup_sched_timer(void)
> -		printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());

and here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/