linux-kernel - Re: [PATCHv3 2/4] usb: gadget: replace "is_dualspeed" with "max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1108231636000.2069-100000@iolanthe.rowland.org>
Date:	Tue, 23 Aug 2011 16:49:37 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mnazarewicz@...gle.com>
cc:	Felipe Balbi <balbi@...com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Yang Rui Rui <ruirui.r.yang@...to.com>,
	Dave Young <hidave.darkstar@...il.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 2/4] usb: gadget: replace "is_dualspeed" with "max_speed"

On Tue, 23 Aug 2011, Michal Nazarewicz wrote:

> On Tue, 23 Aug 2011 20:00:25 +0200, Alan Stern <stern@...land.harvard.edu>  
> wrote:
> > For the time being, perhaps the best answer is to use the _lowest_
> > max_speed value among all the function drivers.  It's the simplest
> > answer and most likely to be correct most of the time.
> 
> In theory, one could create a composite function with only SS/HS
> descriptors.

The only reason for doing that would be if the function was incapable
of carrying out its duties when running at full speed (insufficient
bandwidth, for example).  Something like this is discussed briefly in 
section 9.2.6.6 of the USB-2 spec.

>  So it would work for SS/HS but not for FS.  I'm not
> saying that it would make sense (or that it's not a bug) but that
> adds to the discussion.

If somebody writes a composite gadget containing two functions, one of 
which supports only full speed and the other only high speed, they'll 
get what they deserve.  :-)

Still, maybe I was wrong.  Maybe it would be better to use the fastest
speed supported by at least one of the function drivers.  The user can
always force a SuperSpeed-capable device to run at high speed by using
a USB-2 cable to plug it in.  I'm not sure whether the user could force
such a device to run at full speed, however.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/