linux-kernel - Re: [PATCH v2] Staging: cx25821: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110823214421.GF3679@kroah.com>
Date:	Tue, 23 Aug 2011 14:44:21 -0700
From:	Greg KH <greg@...ah.com>
To:	"Leonid V. Fedorenchik" <leonidsbox@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Palash Bandyopadhyay <Palash.Bandyopadhyay@...exant.com>,
	Ruslan Pisarev <ruslan@...sarev.org.ua>,
	Ilya Gorskin <Revent82@...il.com>,
	Joe Perches <joe@...ches.com>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH v2] Staging: cx25821: fix coding style issues

On Tue, Aug 02, 2011 at 05:03:18PM +0800, Leonid V. Fedorenchik wrote:
> Fix too long lines in cx25821-audio.h
> Fix wrong brace placement in cx25821-cards.c, cx25821-core.c,
> and cx25821-i2c.c
> Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl.
> Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.
> Delete file cx25821-gpio.h since it is not used.
> Get rid of typedef in cx25821.h.

I prefer to get patches in a "one patch per thing you did" format.

So, care to split this up into a number of smaller patches, all doing
the individual thing you list above?

Yes, it's going to be a bunch of small patches, but then they will be
"obviously" correct and trivial to review and apply.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/