linux-kernel - Re: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110823222738.GE15721@kroah.com>
Date:	Tue, 23 Aug 2011 15:27:38 -0700
From:	Greg KH <greg@...ah.com>
To:	Akshay Joshi <me@...hayjoshi.com>
Cc:	Pavel Machek <pavel@....cz>, Greg Kroah-Hartman <gregkh@...e.de>,
	Pekka Enberg <penberg@...nel.org>,
	Ilia Mirkin <imirkin@...m.mit.edu>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.

On Mon, Aug 15, 2011 at 08:24:27PM -0400, Akshay Joshi wrote:
> Split the case statement and the code that is executed if the condition
> is met so that it passes checkpatch.pl and conforms to the kernel code
> style.

Not quite.

Please put the 'break;' on a new line for every case statement.

Care to redo this whole series based on the review comments you got so
far and resend them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/