linux-kernel - RE: [PATCH v2 2/2] omap_twl: Prevent SR to enable for am3517/am3505devices

Open Source and information security mailing list archives

Date:	Wed, 24 Aug 2011 14:03:22 +0530
From:	"Premi, Sanjeev" <premi@...com>
To:	"Sripathy, Vishwanath" <vishwanath.bs@...com>,
	"Koyamangalath, Abhilash" <abhilash.kv@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
CC:	"paul@...an.com" <paul@...an.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"Cousson, Benoit" <b-cousson@...com>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 2/2] omap_twl: Prevent SR to enable for
 am3517/am3505devices

> -----Original Message-----
> From: linux-omap-owner@...r.kernel.org 
> [mailto:linux-omap-owner@...r.kernel.org] On Behalf Of 
> Sripathy, Vishwanath
> Sent: Tuesday, August 23, 2011 7:14 PM
> To: Koyamangalath, Abhilash; linux-omap@...r.kernel.org
> Cc: paul@...an.com; linux@....linux.org.uk; Cousson, Benoit; 
> tony@...mide.com; linux-kernel@...r.kernel.org; Hiremath, 
> Vaibhav; linux-arm-kernel@...ts.infradead.org
> Subject: RE: [PATCH v2 2/2] omap_twl: Prevent SR to enable 
> for am3517/am3505devices
> 
> > -----Original Message-----
> > From: linux-arm-kernel-bounces@...ts.infradead.org [mailto:linux-
> > arm-kernel-bounces@...ts.infradead.org] On Behalf Of Abhilash K V
> > Sent: Tuesday, August 23, 2011 6:51 PM
> > To: linux-omap@...r.kernel.org
> > Cc: paul@...an.com; linux@....linux.org.uk; b-cousson@...com;
> > tony@...mide.com; linux-kernel@...r.kernel.org; Vaibhav Hiremath;
> > Abhilash K V; linux-arm-kernel@...ts.infradead.org
> > Subject: [PATCH v2 2/2] omap_twl: Prevent SR to enable for
> > am3517/am3505devices
> >
> > From: Vaibhav Hiremath <hvaibhav@...com>
> >
> > In case of AM3517 & AM3505, Smart Reflex is not applicable so
> > we must not enable it. So add check for absence of SR feature
> > in omap3_twl_init() and return -ENODEV if absence, else continue.
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@...com>
> > Signed-off-by: Abhilash K V <abhilash.kv@...com>
> > ---
> >  arch/arm/mach-omap2/id.c              |    2 +-
> >  arch/arm/mach-omap2/omap_twl.c        |    8 ++++++++
> >  arch/arm/plat-omap/include/plat/cpu.h |    2 ++
> >  3 files changed, 11 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 37efb86..da71098 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -202,7 +202,7 @@ static void __init omap3_check_features(void)
> >  	if (cpu_is_omap3630())
> >  		omap_features |= OMAP3_HAS_192MHZ_CLK;
> >  	if (!cpu_is_omap3505() && !cpu_is_omap3517())
> > -		omap_features |= OMAP3_HAS_IO_WAKEUP;
> > +		omap_features |= (OMAP3_HAS_IO_WAKEUP | OMAP3_HAS_SR);
> >
> >  	omap_features |= OMAP3_HAS_SDRC;
> >
> > diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-
> > omap2/omap_twl.c
> > index 07d6140..47e27b5 100644
> > --- a/arch/arm/mach-omap2/omap_twl.c
> > +++ b/arch/arm/mach-omap2/omap_twl.c
> > @@ -269,6 +269,14 @@ int __init omap3_twl_init(void)
> >  	if (!cpu_is_omap34xx())
> >  		return -ENODEV;
> >
> > +	/*
> > +	 * In case of AM3517/AM3505 we should not be going down
> > +	 * further, since SR is not applicable there.
> > +	 */
> > +	if (!omap3_has_sr()) {
> > +		return -ENODEV;
> > +	}
> I do not understand what has vp_max and vp_min configuration 
> to do with
> SR. This parameter indicates the maximum and minimum voltage 
> supported by
> respective PM IC.

[sp] omap3_twl_init() shouldn't be executed for AM35x.
     Considering that we are using "SR" as feature, the check
     should be "PMIC" centric not "SR" centric.

~sanjeev

> 
> Vishwa
> 
> > +
> >  	if (cpu_is_omap3630()) {
> >  		omap3_mpu_volt_info.vp_vddmin =
> > OMAP3630_VP1_VLIMITTO_VDDMIN;
> >  		omap3_mpu_volt_info.vp_vddmax =
> > OMAP3630_VP1_VLIMITTO_VDDMAX;
> > diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-
> > omap/include/plat/cpu.h
> > index 67b3d75..294e015 100644
> > --- a/arch/arm/plat-omap/include/plat/cpu.h
> > +++ b/arch/arm/plat-omap/include/plat/cpu.h
> > @@ -491,6 +491,7 @@ extern u32 omap_features;
> >  #define OMAP4_HAS_MPU_1GHZ		BIT(8)
> >  #define OMAP4_HAS_MPU_1_2GHZ		BIT(9)
> >  #define OMAP4_HAS_MPU_1_5GHZ		BIT(10)
> > +#define OMAP3_HAS_SR			BIT(11)
> >
> >
> >  #define OMAP3_HAS_FEATURE(feat,flag)			\
> > @@ -507,6 +508,7 @@ OMAP3_HAS_FEATURE(isp, ISP)
> >  OMAP3_HAS_FEATURE(192mhz_clk, 192MHZ_CLK)
> >  OMAP3_HAS_FEATURE(io_wakeup, IO_WAKEUP)
> >  OMAP3_HAS_FEATURE(sdrc, SDRC)
> > +OMAP3_HAS_FEATURE(sr, SR)
> >
> >  /*
> >   * Runtime detection of OMAP4 features
> > --
> > 1.7.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> --
> To unsubscribe from this list: send the line "unsubscribe 
> linux-omap" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives